Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92287
Change subject: Removed double initialization of input extender in TimeInput
expert
......................................................................
Removed double initialization of input extender in TimeInput expert
(56043)
Since the input extender was initialized twice, the initial update of the
preview
was not triggered.
Change-Id: Ie32066fcb7efbe068d4d0af71d0470ae01021925
---
M ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
1 file changed, 8 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues
refs/changes/87/92287/1
diff --git
a/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
b/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
index 581a467..8748438 100644
---
a/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
+++
b/ValueView/resources/jquery.valueview/valueview.experts/experts.TimeInput.js
@@ -101,6 +101,14 @@
'class': this.uiBaseClass + '-input
valueview-input'
} )
.appendTo( this.$viewPort )
+ .eachchange( function( event, oldValue ) {
+ var value = self.$input.data( 'timeinput'
).value();
+ if( oldValue === '' && value === null ||
self.$input.val() === '' ) {
+ self._updatePreview();
+ self._updateCalendarHint();
+ }
+ } )
+ .timeinput( { mediaWiki: this._options.mediaWiki } )
.inputextender( {
initCallback: function( $extension ) {
self._initInputExtender( $extension );
@@ -115,19 +123,6 @@
self.$calendar.data(
'listrotator' ).rotate( value.calendar() );
}
} );
- }
- } )
- .eachchange( function( event, oldValue ) {
- var value = self.$input.data( 'timeinput'
).value();
- if( oldValue === '' && value === null ||
self.$input.val() === '' ) {
- self._updatePreview();
- self._updateCalendarHint();
- }
- } )
- .timeinput( { mediaWiki: this._options.mediaWiki } )
- .inputextender( {
- initCallback: function( $extension ) {
- self._initInputExtender( $extension );
},
contentAnimationEvents: 'toggleranimation'
} )
--
To view, visit https://gerrit.wikimedia.org/r/92287
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie32066fcb7efbe068d4d0af71d0470ae01021925
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
