Henning Snater has uploaded a new change for review.
https://gerrit.wikimedia.org/r/92322
Change subject: Trigger re-enabling EditableValue after saving successfully
......................................................................
Trigger re-enabling EditableValue after saving successfully
(bug 51307)
By re-enabling the EditableValue after saving, the state of the toolbar items
is set appropriately.
Change-Id: I65a9e706a84d17ec10d4d80fdfa6fcad92fc9f9b
---
M lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
M repo/tests/selenium/item/editonoff_spec.rb
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/22/92322/1
diff --git a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
index 43a90c3..285967c 100644
--- a/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
+++ b/lib/resources/wikibase.ui.PropertyEditTool.EditableValue.js
@@ -597,6 +597,8 @@
self.setValue( responseVal );
}
+ self.enable();
+
if( mw.config.get( 'wbEntityId' ) === null ) {
// if the 'save' process will create a
new item, trigger the event!
$( window.wikibase ).triggerHandler(
'newItemCreated', response.entity );
diff --git a/repo/tests/selenium/item/editonoff_spec.rb
b/repo/tests/selenium/item/editonoff_spec.rb
index 3ecfc67..a329069 100644
--- a/repo/tests/selenium/item/editonoff_spec.rb
+++ b/repo/tests/selenium/item/editonoff_spec.rb
@@ -141,11 +141,20 @@
page.editDescriptionLink?.should be_false
page.addAliases?.should be_false
page.addSitelinkLink?.should be_false
+ page.removeSitelinkLink?.should be_true
page.cancelSitelinkLink
page.editLabelLink?.should be_true
page.editDescriptionLink?.should be_true
page.addAliases?.should be_true
page.addSitelinkLink?.should be_true
+ page.editSitelinkLink
+ page.pageInputFieldExistingSiteLink="England"
+ page.saveSitelinkLink
+ ajax_wait
+ page.wait_for_api_callback
+ page.editSitelinkLink
+ # Check that "remove" button is enabled after editing (bug #51307):
+ page.removeSitelinkLink?.should be_true
end
end
end
--
To view, visit https://gerrit.wikimedia.org/r/92322
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65a9e706a84d17ec10d4d80fdfa6fcad92fc9f9b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Henning Snater <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
