Andrew Bogott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/92326


Change subject: Remove generic::sysfs::enable-rps
......................................................................

Remove generic::sysfs::enable-rps

It's only used in one place and only contains one line.  Having a whole
class for this seems like overkill.

Change-Id: I2f2ef6e367fcf57eeb6eb8dd9d573e4e632dee35
---
M manifests/generic-definitions.pp
M manifests/lvs.pp
2 files changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/26/92326/1

diff --git a/manifests/generic-definitions.pp b/manifests/generic-definitions.pp
index fcbb75b..43d6b2f 100644
--- a/manifests/generic-definitions.pp
+++ b/manifests/generic-definitions.pp
@@ -203,10 +203,6 @@
        }
 }
 
-class generic::sysfs::enable-rps {
-       upstart_job { "enable-rps": install => "true", start => "true" }
-}
-
 # this installs a bunch of international locales, f.e. for "planet" on singer
 class generic::locales::international {
 
diff --git a/manifests/lvs.pp b/manifests/lvs.pp
index a684257..2fc61b4 100644
--- a/manifests/lvs.pp
+++ b/manifests/lvs.pp
@@ -946,6 +946,8 @@
                        'net.ipv4.rt_cache_rebuild_count' => -1,
                },
        }
+
+       upstart_job { "enable-rps": install => "true", start => "true" }
 }
 
 # Supporting the PyBal RunCommand monitor

-- 
To view, visit https://gerrit.wikimedia.org/r/92326
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f2ef6e367fcf57eeb6eb8dd9d573e4e632dee35
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to