MaxSem has submitted this change and it was merged.
Change subject: Golden toast wins
......................................................................
Golden toast wins
the A/B test was 50/50 so the golden toast doesn't effect editing
in a positive or negative way. It would be interesting to keep and
explore in future with other landmarks so it stays.
Change-Id: If5b66a919f2fe4d00c666c9d0a3edbc5437d3a2b
(cherry picked from commit 43360394059e4cc23e794d48bef9217e44549413)
---
M javascripts/modules/editor/EditorOverlay.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
MaxSem: Verified; Looks good to me, approved
diff --git a/javascripts/modules/editor/EditorOverlay.js
b/javascripts/modules/editor/EditorOverlay.js
index cfc9c60..29481d8 100644
--- a/javascripts/modules/editor/EditorOverlay.js
+++ b/javascripts/modules/editor/EditorOverlay.js
@@ -281,8 +281,7 @@
new Page( { title: title, el: $(
'#content_wrapper' ) } ).on( 'ready', M.reloadPage );
M.router.navigate( '' );
self.hide();
- // FIXME: What was the outcome of this
A-B test?
- if ( M.isTestA && self.isNewEditor ) {
+ if ( self.isNewEditor ) {
msg =
'mobile-frontend-editor-success-landmark-1';
} else {
className = 'toast';
--
To view, visit https://gerrit.wikimedia.org/r/92802
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5b66a919f2fe4d00c666c9d0a3edbc5437d3a2b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: wmf1
Gerrit-Owner: MaxSem <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
