Cmcmahon has submitted this change and it was merged. Change subject: hopefully make UW a bit more reliable ......................................................................
hopefully make UW a bit more reliable Change-Id: Ic48a80c239bef23ef237e7546700770bd62eae88 --- M features/step_definitions/upload_wizard_steps.rb 1 file changed, 3 insertions(+), 6 deletions(-) Approvals: Cmcmahon: Looks good to me, approved jenkins-bot: Verified diff --git a/features/step_definitions/upload_wizard_steps.rb b/features/step_definitions/upload_wizard_steps.rb index df8d2a9..55e35a0 100644 --- a/features/step_definitions/upload_wizard_steps.rb +++ b/features/step_definitions/upload_wizard_steps.rb @@ -21,13 +21,13 @@ end When(/^I click Next button at Describe page$/) do sleep 1 # todo # I can not figure out at the moment how to make this work without using sleep - on(DescribePage).next_element.click + on(DescribePage).next_element.when_present.click end When(/^I click Next button at Learn page$/) do on(LearnPage).next_element.when_present(15).click end When(/^I click Next button at Release rights page$/) do - on(ReleaseRightsPage).next_element.when_present.click + on(ReleaseRightsPage).next_element.when_present(15).click end When(/^I click This file is my own work$/) do on(ReleaseRightsPage).select_my_own_work @@ -81,10 +81,7 @@ on(DescribePage).title_element.when_present.should be_visible end Then(/^Upload more files button should be there$/) do - on(UsePage) do |page| - page.upload_more_files_element.when_present - page.upload_more_files_element.should be_visible - end + on(UsePage).upload_more_files_element.when_present.should be_visible end Then(/^Upload page should appear$/) do @browser.url.should match /Special:UploadWizard/ -- To view, visit https://gerrit.wikimedia.org/r/92914 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic48a80c239bef23ef237e7546700770bd62eae88 Gerrit-PatchSet: 2 Gerrit-Project: qa/browsertests Gerrit-Branch: master Gerrit-Owner: Cmcmahon <[email protected]> Gerrit-Reviewer: Cmcmahon <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
