Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/93451
Change subject: (bug 56130) Icons need tooltips
......................................................................
(bug 56130) Icons need tooltips
Bug: 56130
Change-Id: Iac650630a6c8058b1cd4387615ca01175379a56c
---
M Flow.i18n.php
M includes/View/PostActionMenu.php
M templates/header.html.php
M templates/post.html.php
M templates/topic.html.php
M templates/topiclist.html.php
6 files changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/51/93451/1
diff --git a/Flow.i18n.php b/Flow.i18n.php
index 17cdedd..ee5937f 100644
--- a/Flow.i18n.php
+++ b/Flow.i18n.php
@@ -31,8 +31,8 @@
'flow-post-deleted-by' => '{{GENDER:$1|Deleted}} by $1 $2',
'flow-post-censored' => '[post censored]',
'flow-post-censored-by' => '{{GENDER:$1|Censored}} by $1 $2',
- 'flow-post-actions' => 'actions',
- 'flow-topic-actions' => 'actions',
+ 'flow-post-actions' => 'Actions',
+ 'flow-topic-actions' => 'Actions',
'flow-cancel' => 'Cancel',
'flow-newtopic-title-placeholder' => 'Message subject',
diff --git a/includes/View/PostActionMenu.php b/includes/View/PostActionMenu.php
index 056506c..a9da067 100644
--- a/includes/View/PostActionMenu.php
+++ b/includes/View/PostActionMenu.php
@@ -116,6 +116,7 @@
'type' => 'submit',
'class' => $class,
'value' => $content,
+ 'title' => strip_tags( $content ),
) ) .
$output[] = Html::closeElement( 'form' );
@@ -143,6 +144,7 @@
array(
'href' => $url,
'class' => $class,
+ 'title' => strip_tags( $content ),
),
$content
);
diff --git a/templates/header.html.php b/templates/header.html.php
index efb1b39..b46ab04 100644
--- a/templates/header.html.php
+++ b/templates/header.html.php
@@ -37,6 +37,7 @@
array(
'href' => $this->generateUrl( $workflow, 'edit-header' ),
'class' => 'flow-header-edit-link flow-icon
flow-icon-bottom-aligned',
+ 'title' => wfMessage( 'flow-edit-header-link' )->text()
),
wfMessage( 'flow-edit-header-link' )->text()
);
diff --git a/templates/post.html.php b/templates/post.html.php
index 25d0caa..08929f1 100644
--- a/templates/post.html.php
+++ b/templates/post.html.php
@@ -124,7 +124,7 @@
<?php if ( $postActionMenu->isAllowedAny( 'hide-post',
'delete-post', 'censor-post', 'restore-post' ) ): ?>
<div class="flow-actions">
- <a class="flow-actions-link flow-icon
flow-icon-bottom-aligned" href="#"><?php echo wfMessage( 'flow-post-actions'
)->escaped(); ?></a>
+ <a class="flow-actions-link flow-icon
flow-icon-bottom-aligned" href="#" title="<?php echo wfMessage(
'flow-post-actions' )->escaped(); ?>"><?php echo wfMessage( 'flow-post-actions'
)->escaped(); ?></a>
<div class="flow-actions-flyout">
<ul>
<?php
diff --git a/templates/topic.html.php b/templates/topic.html.php
index a0212d7..bef2278 100644
--- a/templates/topic.html.php
+++ b/templates/topic.html.php
@@ -18,13 +18,14 @@
<div class="flow-element-container">
<div class="flow-titlebar mw-ui-button">
<?php
- echo Html::rawElement(
+ echo Html::element(
'a',
array(
'href' => $this->generateUrl(
$root->getPostId(), 'edit-title' ),
'class' => 'flow-edit-topic-link flow-icon
flow-icon-top-aligned',
+ 'title' => wfMessage(
'flow-topic-action-edit-title' )->text(),
),
- wfMessage( 'flow-topic-action-edit-title' )
+ wfMessage( 'flow-topic-action-edit-title' )->text()
);
?>
diff --git a/templates/topiclist.html.php b/templates/topiclist.html.php
index bd7e017..2196459 100644
--- a/templates/topiclist.html.php
+++ b/templates/topiclist.html.php
@@ -21,7 +21,8 @@
// @Todo - Update href to a real link for no-js support
echo Html::element( 'a', array(
'class' => array( 'flow-new-topic-link', 'flow-icon',
'flow-icon-bottom-aligned' ),
- 'href' => '#'
+ 'href' => '#',
+ 'title' => wfMessage( 'flow-newtopic-start-placeholder' )->text(),
), wfMessage( 'flow-newtopic-start-placeholder' )->text() );
if ( $block->hasErrors( 'content' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/93451
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac650630a6c8058b1cd4387615ca01175379a56c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
