jenkins-bot has submitted this change and it was merged. Change subject: Fix editing of posts ......................................................................
Fix editing of posts https://gerrit.wikimedia.org/r/#/c/91306/ has introduced a small regression because data-post-id is no longer duplicated on both .flow-post-container and .flow-post elements. This JS was still looking at the one where the data attribute was now removed. Change-Id: I7593f8515bfcec7ddf74e22942efeb3ebdc2928b --- M modules/discussion/forms.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Werdna: Looks good to me, approved Bsitu: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/discussion/forms.js b/modules/discussion/forms.js index e7eb861..2b8bf7f 100644 --- a/modules/discussion/forms.js +++ b/modules/discussion/forms.js @@ -128,7 +128,7 @@ $contentContainer = $post.find( '.flow-post-content' ), workflowId = $( this ).flow( 'getTopicWorkflowId' ), pageName = $( this ).closest( '.flow-container' ).data( 'page-title' ), - postId = $post.data( 'post-id' ); + postId = $post.closest( '.flow-post-container' ).data( 'post-id' ); if ( $post.find( '.flow-edit-post-form' ).length ) { return; -- To view, visit https://gerrit.wikimedia.org/r/93485 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7593f8515bfcec7ddf74e22942efeb3ebdc2928b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org> Gerrit-Reviewer: Bsitu <bs...@wikimedia.org> Gerrit-Reviewer: EBernhardson <ebernhard...@wikimedia.org> Gerrit-Reviewer: Werdna <agarr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
