Njw has submitted this change and it was merged. Change subject: Remove $wgEruditeBannerImg usage ......................................................................
Remove $wgEruditeBannerImg usage Mediawiki:Common.css should be the place to customise this (as will be documented on the Skin:Erudite wiki page soon) Change-Id: I42759d309ce8d2b5f67a23aa1f5c3da0441eff25 --- M Erudite.skin.php 1 file changed, 2 insertions(+), 9 deletions(-) Approvals: Njw: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/Erudite.skin.php b/Erudite.skin.php index e45d58e..1698736 100644 --- a/Erudite.skin.php +++ b/Erudite.skin.php @@ -57,8 +57,6 @@ * outputs a formatted page. */ public function execute() { - global $wgEruditeBannerImg; - $this->html( 'headelement' ); if ( !isset( $this->data['sitename'] ) ) { @@ -77,13 +75,8 @@ <div id="wrapper" class="hfeed"> <!-- header --> - <?php - if ( isset( $wgEruditeBannerImg ) ) { - echo "<div id='header-wrap' style='background-image: url($wgEruditeBannerImg)'>"; - } else { - echo '<div id="header-wrap">'; - } - ?> + <div id="header-wrap"> + <div id="header" role="banner"> <h1 id="siteTitle"><a href="<?php echo htmlspecialchars( $this->data['nav_urls']['mainpage']['href'] ) ?>" title="<?php $this->text( 'sitename' ); ?>" rel="home"><?php $this->text( 'sitename' ); ?></a></h1> <div id="tagline"><?php $this->msg( 'tagline' ) ?></div> -- To view, visit https://gerrit.wikimedia.org/r/93671 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42759d309ce8d2b5f67a23aa1f5c3da0441eff25 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/skins/erudite Gerrit-Branch: master Gerrit-Owner: Njw <nick.wh...@durham.ac.uk> Gerrit-Reviewer: Njw <nick.wh...@durham.ac.uk> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits