Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/94689


Change subject: Add the log entry after we know the job is successful
......................................................................

Add the log entry after we know the job is successful

Change-Id: I92595eaf6509567d63ee710fefc57441e5f943c7
---
M SpecialMassMessage.php
1 file changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MassMessage 
refs/changes/89/94689/1

diff --git a/SpecialMassMessage.php b/SpecialMassMessage.php
index 96962f3..bc6b91e 100644
--- a/SpecialMassMessage.php
+++ b/SpecialMassMessage.php
@@ -327,15 +327,16 @@
                        $spamlist->getFullURL( '', false, PROTO_CANONICAL )
                );
 
-               // Log it.
-               $this->logToWiki( $spamlist, $data['subject'] );
-
                // Insert it into the job queue.
                $pages = MassMessage::getParserFunctionTargets( $spamlist, 
$this->getContext() );
                if ( !is_array( $pages ) ) {
                        $this->status->fatal( $pages );
                        return $this->status;
                }
+
+               // Log it.
+               $this->logToWiki( $spamlist, $data['subject'] );
+
                $params = array( 'data' => $data, 'pages' => $pages );
                $job = new MassMessageSubmitJob( $spamlist, $params );
                JobQueueGroup::singleton()->push( $job );

-- 
To view, visit https://gerrit.wikimedia.org/r/94689
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I92595eaf6509567d63ee710fefc57441e5f943c7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MassMessage
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to