Matthias Mullie has uploaded a new change for review.
https://gerrit.wikimedia.org/r/94873
Change subject: Get rid of 3rd argument in calls to Templating::renderPost()
......................................................................
Get rid of 3rd argument in calls to Templating::renderPost()
3rd parameter is $return, not some instance of PostRevision; root post being
tossed in is incorrect
Change-Id: I4f48cf1b198e687d56d844206b95ef6b1b5b3c9e
---
M includes/Block/Topic.php
M templates/topic.html.php
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/73/94873/1
diff --git a/includes/Block/Topic.php b/includes/Block/Topic.php
index f3c1c06..aa322a1 100644
--- a/includes/Block/Topic.php
+++ b/includes/Block/Topic.php
@@ -292,7 +292,7 @@
};
} else {
$renderFunction = function( $templating ) use (
$self, $newRevision, $rootPost ) {
- return $templating->renderPost(
$newRevision, $self, $rootPost );
+ return $templating->renderPost(
$newRevision, $self );
};
}
diff --git a/templates/topic.html.php b/templates/topic.html.php
index 6ed41b7..5ba16fa 100644
--- a/templates/topic.html.php
+++ b/templates/topic.html.php
@@ -134,7 +134,7 @@
</div>
<?php
foreach( $root->getChildren() as $child ) {
- echo $this->renderPost( $child, $block, $root );
+ echo $this->renderPost( $child, $block );
}
if ( $permissions->isAllowed( $root, 'reply' ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/94873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f48cf1b198e687d56d844206b95ef6b1b5b3c9e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
