jenkins-bot has submitted this change and it was merged.
Change subject: Use data-i18n for system font l10n
......................................................................
Use data-i18n for system font l10n
This ensures that the translation is updated properly in the
language live preview.
Bug: 56888
Change-Id: I320c570f9272e8d191144f66a9cf0079c89d201d
---
M resources/js/ext.uls.displaysettings.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Santhosh: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.uls.displaysettings.js
b/resources/js/ext.uls.displaysettings.js
index 8c3f806..811adea 100644
--- a/resources/js/ext.uls.displaysettings.js
+++ b/resources/js/ext.uls.displaysettings.js
@@ -419,9 +419,11 @@
}
} );
+ // Using attr() instead of data() because jquery.i18n
doesn't
+ // currently see latter.
$systemFont = $( '<option>' )
.val( 'system' )
- .text( $.i18n( 'ext-uls-webfonts-system-font' )
);
+ .attr( 'data-i18n',
'ext-uls-webfonts-system-font' );
$fontSelector.append( $systemFont );
$systemFont.attr( 'selected', savedFont === 'system' ||
!savedFont );
--
To view, visit https://gerrit.wikimedia.org/r/95117
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I320c570f9272e8d191144f66a9cf0079c89d201d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
