Henning Snater has submitted this change and it was merged.
Change subject: jQuery.valueview minor options optimization
......................................................................
jQuery.valueview minor options optimization
Change-Id: I20aff1b24e39101c803be8968385d83c9d40a17e
---
M ValueView/resources/jquery.valueview/valueview.valueview.js
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Henning Snater: Looks good to me, approved
diff --git a/ValueView/resources/jquery.valueview/valueview.valueview.js
b/ValueView/resources/jquery.valueview/valueview.valueview.js
index 8ac1ec7..1a45e4c 100644
--- a/ValueView/resources/jquery.valueview/valueview.valueview.js
+++ b/ValueView/resources/jquery.valueview/valueview.valueview.js
@@ -178,14 +178,21 @@
/**
* @see jQuery.widget._setOption
+ * @triggers {Error} when trying to set an option that cannot be set
after initialization.
*/
_setOption: function( key, value ) {
+ switch( key ) {
+ case 'autoStartEditing':
+ // doesn't make sense to change this after
initialization
+ throw new Error( 'Can not change
jQuery.valueview option "' + key
+ + '" after widget initialization' );
+ }
+
PARENT.prototype._setOption.call( this, key, value );
switch( key ) {
- case 'autoStartEditing':
- break; // doesn't make sense to change this
after initialization
case 'expertProvider':
+ case 'on': // TODO: make this work properly and test
this._updateExpert();
break;
case 'value':
--
To view, visit https://gerrit.wikimedia.org/r/92423
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20aff1b24e39101c803be8968385d83c9d40a17e
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Werner <daniel.a.r.wer...@gmail.com>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
