jenkins-bot has submitted this change and it was merged. Change subject: Fix WikitextContentHandlerTest::testMakeRedirectContent() when content language is not english ......................................................................
Fix WikitextContentHandlerTest::testMakeRedirectContent() when content language is not english Clear the MagicWord object cache, otherwise the magic word names can be cached in the wrong language, thus making the test fail. Change-Id: Ia6da94ca2c4f9ca892c81b4aa7cf96108b42ccd5 --- M tests/phpunit/includes/content/WikitextContentHandlerTest.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Daniel Kinzler: Looks good to me, approved Liangent: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/tests/phpunit/includes/content/WikitextContentHandlerTest.php b/tests/phpunit/includes/content/WikitextContentHandlerTest.php index 75a7278..7c62dca 100644 --- a/tests/phpunit/includes/content/WikitextContentHandlerTest.php +++ b/tests/phpunit/includes/content/WikitextContentHandlerTest.php @@ -79,6 +79,8 @@ global $wgContLang; $wgContLang->resetNamespaces(); + MagicWord::clearCache(); + if ( is_string( $title ) ) { $title = Title::newFromText( $title ); } -- To view, visit https://gerrit.wikimedia.org/r/94892 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6da94ca2c4f9ca892c81b4aa7cf96108b42ccd5 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: IAlex <coderev...@emsenhuber.ch> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Liangent <liang...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits