jenkins-bot has submitted this change and it was merged.
Change subject: QA: Attempt to get around bogus failure to type password
......................................................................
QA: Attempt to get around bogus failure to type password
Change-Id: Ie97459a993f1181bbcf6854ce0be2dbdcca06d9a
---
M tests/browser/features/support/pages/login_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/support/pages/login_page.rb
b/tests/browser/features/support/pages/login_page.rb
index 64f1c9a..b83be0e 100644
--- a/tests/browser/features/support/pages/login_page.rb
+++ b/tests/browser/features/support/pages/login_page.rb
@@ -19,8 +19,8 @@
@browser.div(id: 'mw-content-text').p.b
end
def login_with(username, password)
- self.username = username
- self.password = password
+ self.username_element.when_present.send_keys(username)
+ self.password_element.when_present.send_keys(password)
login
end
end
--
To view, visit https://gerrit.wikimedia.org/r/94273
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie97459a993f1181bbcf6854ce0be2dbdcca06d9a
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Awjrichards <aricha...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Jhall <jh...@wikimedia.org>
Gerrit-Reviewer: Mgrover <mgro...@wikimedia.org>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
