Spage has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95566
Change subject: minor LESS CSS fixes (zero units, dimensions)
......................................................................
minor LESS CSS fixes (zero units, dimensions)
A few zero values included units, and some margin and padding dimensions
had redundant values on the end. Regarding the latter, since CSS 1 "if
there are two or three, the missing values are taken from the opposite
side". Leaving values off hurts clarity (I can never remember if the
order is top-left-bottom-right) but both Chromium and Firebug's CSS
inspector will display
margin: 0 0 15px 0;
as
margin: 0 0 15px;
anyway.
Bug: 57083
Change-Id: Ic51b2ac196a434857f19d51cd2a92686d53c4877
---
M resources/mediawiki.ui/components/default/buttons.less
M resources/mediawiki.ui/components/default/forms.less
M resources/mediawiki.ui/mixins/forms.less
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/66/95566/1
diff --git a/resources/mediawiki.ui/components/default/buttons.less
b/resources/mediawiki.ui/components/default/buttons.less
index 10d36ff..ead3646 100644
--- a/resources/mediawiki.ui/components/default/buttons.less
+++ b/resources/mediawiki.ui/components/default/buttons.less
@@ -7,7 +7,7 @@
.mw-ui-button {
// Container layout
display: inline-block;
- padding: 0.4em 1em 0.4em 1em;
+ padding: 0.4em 1em;
margin: 0;
// IE6/IE7 hack
diff --git a/resources/mediawiki.ui/components/default/forms.less
b/resources/mediawiki.ui/components/default/forms.less
index d2554c6..0698132 100644
--- a/resources/mediawiki.ui/components/default/forms.less
+++ b/resources/mediawiki.ui/components/default/forms.less
@@ -46,7 +46,7 @@
.box-sizing(border-box);
.agora-label-styling();
width: auto;
- margin: 0 0 0.2em 0;
+ margin: 0 0 0.2em;
padding: 0;
}
@@ -66,7 +66,7 @@
.error {
.box-sizing(border-box);
font-size: 0.9em;
- margin: 0 0 1em 0;
+ margin: 0 0 1em;
padding: 0.5em;
color: #cc0000;
border: 1px solid #fac5c5;
@@ -86,7 +86,7 @@
// XXX DRY: This repeats earlier styling, use an @include agora-div-styling ?
.mw-ui-vform-div {
display: block;
- margin: 0 0 15px 0;
+ margin: 0 0 15px;
padding: 0;
width: 100%;
}
diff --git a/resources/mediawiki.ui/mixins/forms.less
b/resources/mediawiki.ui/mixins/forms.less
index 76329b1..8280639 100644
--- a/resources/mediawiki.ui/mixins/forms.less
+++ b/resources/mediawiki.ui/mixins/forms.less
@@ -12,7 +12,7 @@
outline: 0; // Removes OS field focus
}
- box-shadow: @agoraBlueShadow 0px 0px 5px;
+ box-shadow: @agoraBlueShadow 0 0 5px;
border-color: @agoraBlueShadow;
}
@@ -43,7 +43,7 @@
& > input[type="radio"] {
width: auto;
height: auto;
- margin: 0 0.1em 0em 0;
+ margin: 0 0.1em 0 0;
padding: 0;
border: 1px solid @agoraGray;
cursor: pointer;
--
To view, visit https://gerrit.wikimedia.org/r/95566
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic51b2ac196a434857f19d51cd2a92686d53c4877
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Spage <sp...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
