Akosiaris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/95601
Change subject: Fix owner/perms for misc/logging.pp
......................................................................
Fix owner/perms for misc/logging.pp
Not defined so would default on puppetmaster's filesystem values
Change-Id: Ibd60242e4cdbac79b1046fb6e6573f4ad3a89833
---
M manifests/misc/logging.pp
1 file changed, 14 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/01/95601/1
diff --git a/manifests/misc/logging.pp b/manifests/misc/logging.pp
index c1b8659..6698e2a 100644
--- a/manifests/misc/logging.pp
+++ b/manifests/misc/logging.pp
@@ -9,20 +9,24 @@
}
file { "/etc/syslog-ng/syslog-ng.conf":
- require => Package[syslog-ng],
- source => "puppet:///files/syslog-ng/syslog-ng.conf.${config}",
- mode => 0444;
+ owner => 'root',
+ group => 'root',
+ mode => '0444',
+ source => "puppet:///files/syslog-ng/syslog-ng.conf.${config}",
+ require => Package['syslog-ng'],
}
# FIXME: handle properly
if $config == "nfs" {
- file { "/etc/logrotate.d/remote-logs":
- source => "puppet:///files/syslog-ng/remote-logs",
- mode => 0444;
- "/home/wikipedia/syslog":
- owner => root,
- group => root,
- mode => 0755;
+ file { '/etc/logrotate.d/remote-logs':
+ owner => 'root',
+ group => 'root',
+ mode => '0444',
+ source => 'puppet:///files/syslog-ng/remote-logs';
+ '/home/wikipedia/syslog':
+ owner => 'root',
+ group => 'root',
+ mode => '0755';
}
}
--
To view, visit https://gerrit.wikimedia.org/r/95601
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd60242e4cdbac79b1046fb6e6573f4ad3a89833
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Akosiaris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
