[MediaWiki-commits] [Gerrit] Add some phpdocs for IDEs - change (mediawiki...EventLogging)

[Addshore (Code Review)]

Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/95769


Change subject: Add some phpdocs for IDEs
......................................................................

Add some phpdocs for IDEs

Change-Id: I1409c5130a2e3a414494f4ae21caf40510af4fa3
---
M includes/ApiJsonSchema.php
M tests/RemoteSchemaTest.php
M tests/ResourceLoaderSchemaModuleTest.php
3 files changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/EventLogging 
refs/changes/69/95769/1

diff --git a/includes/ApiJsonSchema.php b/includes/ApiJsonSchema.php
index df039b7..59540ec 100644
--- a/includes/ApiJsonSchema.php
+++ b/includes/ApiJsonSchema.php
@@ -91,6 +91,7 @@
                        $this->dieUsageMsg( array( 'invalidtitle', $title ) );
                }
 
+               /** @var JsonSchemaContent $content */
                $content = $rev->getContent();
                if ( !$content ) {
                        $this->dieUsageMsg( array( 'nosuchrevid', 
$params['revid'] ) );
diff --git a/tests/RemoteSchemaTest.php b/tests/RemoteSchemaTest.php
index 84a8d8a..cc9f037 100644
--- a/tests/RemoteSchemaTest.php
+++ b/tests/RemoteSchemaTest.php
@@ -14,8 +14,17 @@
  */
 class RemoteSchemaTest extends MediaWikiTestCase {
 
+       /**
+        * @var PHPUnit_Framework_MockObject_MockObject
+        */
        var $cache;
+       /**
+        * @var PHPUnit_Framework_MockObject_MockObject
+        */
        var $http;
+       /**
+        * @var RemoteSchema
+        */
        var $schema;
 
        var $statusSchema = array( 'status' => array( 'type' => 'string' ) );
diff --git a/tests/ResourceLoaderSchemaModuleTest.php 
b/tests/ResourceLoaderSchemaModuleTest.php
index 3256a73..da68931 100644
--- a/tests/ResourceLoaderSchemaModuleTest.php
+++ b/tests/ResourceLoaderSchemaModuleTest.php
@@ -18,7 +18,13 @@
        const REV = 99;
 
        var $context;
+       /**
+        * @var ResourceLoaderSchemaModule
+        */
        var $module;
+       /**
+        * @var PHPUnit_Framework_MockObject_MockObject
+        */
        var $schema;
 
 

-- 
To view, visit https://gerrit.wikimedia.org/r/95769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1409c5130a2e3a414494f4ae21caf40510af4fa3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/EventLogging
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits