QChris has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96011
Change subject: Clarify use of "--globals" in getSlaveServerTest
......................................................................
Clarify use of "--globals" in getSlaveServerTest
Change-Id: Ie0d572bfc8ca655d27f4db559fb237c33f76e9f2
---
M tests/phpunit/maintenance/getSlaveServerTest.php
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/11/96011/1
diff --git a/tests/phpunit/maintenance/getSlaveServerTest.php
b/tests/phpunit/maintenance/getSlaveServerTest.php
index bb678af..0d7eb63 100644
--- a/tests/phpunit/maintenance/getSlaveServerTest.php
+++ b/tests/phpunit/maintenance/getSlaveServerTest.php
@@ -44,6 +44,11 @@
global $wgDBprefix;
global $argv;
+ // Although we'd prefer to not dump globals, dumping globals
actually
+ // models the use case from the xmldumps-backup scripts that
WMF uses
+ // to dump wikis (as of 2013-11-18). See
+ //
http://git.wikimedia.org/blob/operations%2Fdumps.git/11e9b23b4bc76bf3d89e1fb32348c7a11079bd55/xmldumps-backup%2Fworker.py#L209
+ // So as wmf's xml dumps rely on "--globals", we have to test
it :-(
$argv = array( null, "--globals" );
$gss = new GetSlaveServer();
--
To view, visit https://gerrit.wikimedia.org/r/96011
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0d572bfc8ca655d27f4db559fb237c33f76e9f2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: QChris <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
