EBernhardson has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/96173


Change subject: Simplify LESS .buttonIcon method
......................................................................

Simplify LESS .buttonIcon method

Change-Id: Ib99057f5194b2b5e1498e4688c3807e3f1be91f1
---
M modules/discussion/styles/post.less
1 file changed, 19 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow 
refs/changes/73/96173/1

diff --git a/modules/discussion/styles/post.less 
b/modules/discussion/styles/post.less
index 661524f..0d06ce1 100644
--- a/modules/discussion/styles/post.less
+++ b/modules/discussion/styles/post.less
@@ -107,8 +107,22 @@
                }
        }
 
+
        // Add icon to action buttons
-       .buttonIcon(
+    .buttonIcon(@icon-prefix) {
+        .buttonIconExplicit(
+            ~"@{icon-prefix}_active.svg", 
+            ~"@{icon-prefix}_active.png",
+            ~"@{icon-prefix}_hover.svg", 
+            ~"@{icon-prefix}_hover.png",
+            ~"@{icon-prefix}_normal.svg", 
+            ~"@{icon-prefix}_normal.png",
+            ~"@{icon-prefix}_onclick.svg", 
+            ~"@{icon-prefix}_onclick.png",
+        );
+       }
+
+       .buttonIconExplicit(
                @active-icon,
                @active-fallback-icon,
 
@@ -139,56 +153,20 @@
        }
 
        .flow-hide-post-link {
-               .buttonIcon(
-                       '../../base/images/moderate_menu_hidden_active.svg',
-                       '../../base/images/moderate_menu_hidden_active.png',
-
-                       '../../base/images/moderate_menu_hidden_hover.svg',
-                       '../../base/images/moderate_menu_hidden_hover.png',
-
-                       '../../base/images/moderate_menu_hidden_normal.svg',
-                       '../../base/images/moderate_menu_hidden_normal.png',
-
-                       '../../base/images/moderate_menu_hidden_onclick.svg',
-                       '../../base/images/moderate_menu_hidden_onclick.png'
-               );
+               .buttonIcon( '../../base/images/moderate_menu_hidden' );
        }
 
        .flow-delete-post-link {
-               .buttonIcon(
-                       '../../base/images/moderate_menu_deleted_active.svg',
-                       '../../base/images/moderate_menu_deleted_active.png',
-
-                       '../../base/images/moderate_menu_deleted_hover.svg',
-                       '../../base/images/moderate_menu_deleted_hover.png',
-
-                       '../../base/images/moderate_menu_deleted_normal.svg',
-                       '../../base/images/moderate_menu_deleted_normal.png',
-
-                       '../../base/images/moderate_menu_deleted_onclick.svg',
-                       '../../base/images/moderate_menu_deleted_onclick.png'
-               );
+               .buttonIcon( '../../base/images/moderate_menu_deleted' );
        }
 
        .flow-censor-post-link {
-               .buttonIcon(
-                       '../../base/images/moderate_menu_suppressed_active.svg',
-                       '../../base/images/moderate_menu_suppressed_active.png',
-
-                       '../../base/images/moderate_menu_suppressed_hover.svg',
-                       '../../base/images/moderate_menu_suppressed_hover.png',
-
-                       '../../base/images/moderate_menu_suppressed_normal.svg',
-                       '../../base/images/moderate_menu_suppressed_normal.png',
-
-                       
'../../base/images/moderate_menu_suppressed_onclick.svg',
-                       '../../base/images/moderate_menu_suppressed_onclick.png'
-               );
+               .buttonIcon( '../../base/images/moderate_menu_suppressed' );
        }
 
        .flow-restore-post-link {
                // @todo: need icon
-//             .buttonIcon('../../base/images/restored_button.svg', 
'../../base/images/restored_button.png');
+               // .buttonIcon( '../../base/images/moderate_menu_restored' );
        }
 
        // any non-first-level reply

-- 
To view, visit https://gerrit.wikimedia.org/r/96173
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib99057f5194b2b5e1498e4688c3807e3f1be91f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: EBernhardson <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to