Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/96208
Change subject: Use addPlugin() to register VE listener
......................................................................
Use addPlugin() to register VE listener
Functions added using addPlugin() always run when VE is loaded, whereas
the activation hook only fires when VE has successfully initialized,
which means we miss events fired from code paths that don't lead to
successful activation.
Change-Id: I7e059e759b722a1723b77f5d9b14afbf116d04c1
---
M modules/ext.wikimediaEvents.ve.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/08/96208/1
diff --git a/modules/ext.wikimediaEvents.ve.js
b/modules/ext.wikimediaEvents.ve.js
index 743322d..576b3d0 100644
--- a/modules/ext.wikimediaEvents.ve.js
+++ b/modules/ext.wikimediaEvents.ve.js
@@ -32,8 +32,11 @@
return parsed;
}
+ if ( !mw.libs || !mw.libs.ve || !mw.libs.ve.addPlugin ) {
+ return;
+ }
- mw.hook( 've.activationComplete' ).add( function () {
+ mw.libs.ve.addPlugin( function () {
if ( !ve.trackSubscribe ) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/96208
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e059e759b722a1723b77f5d9b14afbf116d04c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
