http://www.mediawiki.org/wiki/Special:Code/MediaWiki/54780
Revision: 54780
Author: catrope
Date: 2009-08-11 10:42:54 +0000 (Tue, 11 Aug 2009)
Log Message:
-----------
UsabilityInitiative: Use array.push(foo); instead of array[array.length] = foo;
and fix an E_NOTICE
Modified Paths:
--------------
trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js
Modified: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
===================================================================
--- trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
2009-08-11 10:19:28 UTC (rev 54779)
+++ trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
2009-08-11 10:42:54 UTC (rev 54780)
@@ -31,7 +31,7 @@
private static $scripts = array();
private static $scriptFiles = array(
'tests' => array(
- array( 'src' => 'js/tests/wikiEditor.toolbar.js' )
+ array( 'src' => 'js/tests/wikiEditor.toolbar.js',
'version' => 0 )
),
// Code to include when js2 is not present
'no_js2' => array(
Modified: trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js
===================================================================
--- trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js
2009-08-11 10:19:28 UTC (rev 54779)
+++ trunk/extensions/UsabilityInitiative/js/tests/wikiEditor.toolbar.js
2009-08-11 10:42:54 UTC (rev 54780)
@@ -62,8 +62,8 @@
wikiEditorTests[test].data
);
var pass = ui.find( wikiEditorTests[test].test
).size() == 0;
- messages[messages.length] =
- test + ':' + ( pass ? 'PASS' : 'FAIL' );
+ messages.push (
+ test + ':' + ( pass ? 'PASS' : 'FAIL' )
);
if ( pass ) {
passes++;
}
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
