http://www.mediawiki.org/wiki/Special:Code/MediaWiki/54833
Revision: 54833
Author: nimishg
Date: 2009-08-12 00:32:03 +0000 (Wed, 12 Aug 2009)
Log Message:
-----------
fixed issues from r54821
Modified Paths:
--------------
trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.php
Modified:
trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
===================================================================
--- trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
2009-08-12 00:24:29 UTC (rev 54832)
+++ trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.hooks.php
2009-08-12 00:32:03 UTC (rev 54833)
@@ -11,7 +11,7 @@
/* Static Functions */
public static function schema() {
- global $wgExtNewTables, $wgExtNewFields;
+ global $wgExtNewTables;
$wgExtNewTables[] = array(
'click_tracking',
@@ -29,26 +29,23 @@
* @param $contribs contributions the user has made (or NULL if user
not logged in)
* @return true if the event was stored in the DB
*/
- public static function trackEvent($is_logged_in, $namespace, $event_id,
$contribs=-1){
+ public static function trackEvent($is_logged_in, $namespace, $event_id,
$contribs=0){
$dbw = wfGetDB( DB_MASTER );
- if ($contribs < 0) { //meaning the user is not logged in
- $contribs = "NULL";
- }
-
+
$dbw->begin();
// Builds insert information
+
$data = array(
- 'is_logged_in' => $is_logged_in,
+ 'is_logged_in' => (bool) $is_logged_in,
'namespace' => (int) $namespace,
'event_id' => (int) $event_id,
- 'user_contribs' => $contribs
+ 'user_contribs' => ($is_logged_in?$contribs:null)
);
$db_status = $dbw->insert('click_tracking', $data, __METHOD__);
$dbw->commit();
return $db_status;
}
-
-
+
}
\ No newline at end of file
Modified: trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.php
===================================================================
--- trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.php
2009-08-12 00:24:29 UTC (rev 54832)
+++ trunk/extensions/UsabilityInitiative/ClickTracking/ClickTracking.php
2009-08-12 00:32:03 UTC (rev 54833)
@@ -18,8 +18,6 @@
/* Configuration */
-$wgClickTrackStyleVersion = 1;
-
//functions should check if this is set before logging clicktrack events
$wgClickTrackEnabled = true;
@@ -29,8 +27,7 @@
'name' => 'Click Tracking',
'author' => 'Nimish Gautam',
'version' => '0.1.1',
- 'url' => 'http://www.mediawiki.org/wiki/Extension:UsabilityInitiative',
- 'descriptionmsg' => 'clicktracking-desc',
+ 'url' => 'http://www.mediawiki.org/wiki/Extension:UsabilityInitiative'
);
// Includes parent extension
@@ -41,4 +38,3 @@
dirname( __FILE__ ) . '/ClickTracking.hooks.php';
$wgHooks['LoadExtensionSchemaUpdates'][] = 'ClickTrackingHooks::schema';
-
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
