http://www.mediawiki.org/wiki/Special:Code/MediaWiki/55480

Revision: 55480
Author:   demon
Date:     2009-08-22 16:50:03 +0000 (Sat, 22 Aug 2009)

Log Message:
-----------
Merge r53381 from wmf-deployment. Throw more informational error on creation 
failure.

Modified Paths:
--------------
    trunk/phase3/includes/GlobalFunctions.php

Property Changed:
----------------
    trunk/phase3/includes/


Property changes on: trunk/phase3/includes
___________________________________________________________________
Added: svn:mergeinfo
   + /branches/REL1_15/phase3/includes:51646
/branches/wmf-deployment/includes:53381

Modified: trunk/phase3/includes/GlobalFunctions.php
===================================================================
--- trunk/phase3/includes/GlobalFunctions.php   2009-08-22 15:24:50 UTC (rev 
55479)
+++ trunk/phase3/includes/GlobalFunctions.php   2009-08-22 16:50:03 UTC (rev 
55480)
@@ -2074,7 +2074,12 @@
        if ( is_null( $mode ) )
                $mode = $wgDirectoryMode;
 
-       return mkdir( $dir, $mode, true );  // PHP5 <3
+       $ok = mkdir( $dir, $mode, true );  // PHP5 <3
+       if( !$ok ) {
+               // PHP doesn't report the path in its warning message, so add 
our own to aid in diagnosis.
+               trigger_error( __FUNCTION__ . ": failed to mkdir \"$dir\" mode 
$mode", E_USER_WARNING );
+       }
+       return $ok;
 }
 
 /**



_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to