http://www.mediawiki.org/wiki/Special:Code/MediaWiki/65696

Revision: 65696
Author:   avar
Date:     2010-04-30 16:12:20 +0000 (Fri, 30 Apr 2010)

Log Message:
-----------
Fix one-dir off error with the envCheckWriteableDir check

The config-dir-not-writable message excepts $IP, not $IP/config.

Before it would tell you to:

    cd /home/avar/src/mw-git/new-installer/phase3/config
    chmod a+w config

Which didn't make sense since you were already in the config
directory. Now it says this, as in the old installer:

    cd /home/avar/src/mw-git/new-installer/phase3
    chmod a+w config

Modified Paths:
--------------
    branches/new-installer/phase3/includes/installer/Installer.php

Modified: branches/new-installer/phase3/includes/installer/Installer.php
===================================================================
--- branches/new-installer/phase3/includes/installer/Installer.php      
2010-04-30 16:03:27 UTC (rev 65695)
+++ branches/new-installer/phase3/includes/installer/Installer.php      
2010-04-30 16:12:20 UTC (rev 65696)
@@ -608,9 +608,10 @@
 
        /** Environment check for writable config/ directory */
        function envCheckWriteableDir() {
-               $configDir = $this->getVar( 'IP' ) . '/config';
+               $ipDir = $this->getVar( 'IP' );
+               $configDir = $ipDir . '/config';
                if( !is_writeable( $configDir ) ) {
-                       $this->showMessage( 'config-dir-not-writable', 
$configDir );
+                       $this->showMessage( 'config-dir-not-writable', $ipDir );
                        return false;
                }
        }



_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to