http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66606
Revision: 66606 Author: hartman Date: 2010-05-18 11:41:58 +0000 (Tue, 18 May 2010) Log Message: ----------- Followup r66566. wgUploadNavigationUrl is an external link. Modified Paths: -------------- trunk/phase3/includes/Skin.php Modified: trunk/phase3/includes/Skin.php =================================================================== --- trunk/phase3/includes/Skin.php 2010-05-18 05:28:24 UTC (rev 66605) +++ trunk/phase3/includes/Skin.php 2010-05-18 11:41:58 UTC (rev 66606) @@ -1992,19 +1992,17 @@ global $wgUploadNavigationUrl; if( $wgUploadNavigationUrl ) { - $title = Title::newFromText( $wgUploadNavigationUrl ); + # Using an empty class attribute to avoid automatic setting of "external" class + return $this->makeExternalLink( $wgUploadNavigationUrl, wfMsgHtml( 'upload' ), false, null, array( 'class' => '') ); + } else { + return $this->link( + SpecialPage::getTitleFor('Upload'), + wfMsgHtml( 'upload' ), + array(), + array(), + array( 'known', 'noclasses' ) + ); } - if( !isset( $title ) ) { - $title = SpecialPage::getTitleFor('Upload'); - } - - return $this->link( - $title, - wfMsgHtml( 'upload' ), - array(), - array(), - array( 'known', 'noclasses' ) - ); } /* these are used extensively in SkinTemplate, but also some other places */ _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs