http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70591
Revision: 70591
Author: reedy
Date: 2010-08-06 20:19:17 +0000 (Fri, 06 Aug 2010)
Log Message:
-----------
kill some $result->free()
Add getPropChangeUsers() incase liangent does want to email taggers/status
changers also...
Modified Paths:
--------------
trunk/extensions/CodeReview/backend/CodeRevision.php
Modified: trunk/extensions/CodeReview/backend/CodeRevision.php
===================================================================
--- trunk/extensions/CodeReview/backend/CodeRevision.php 2010-08-06
20:05:07 UTC (rev 70590)
+++ trunk/extensions/CodeReview/backend/CodeRevision.php 2010-08-06
20:19:17 UTC (rev 70591)
@@ -504,7 +504,6 @@
foreach ( $result as $row ) {
$comments[] = CodeComment::newFromRow( $this, $row );
}
- $result->free();
return $comments;
}
@@ -531,9 +530,25 @@
foreach ( $result as $row ) {
$changes[] = CodePropChange::newFromRow( $this, $row );
}
- $result->free();
return $changes;
}
+
+ public function getPropChangeUsers() {
+ $dbr = wfGetDB( DB_SLAVE );
+ $result = $dbr->select( 'code_prop_changes',
+ 'DISTINCT(cpc_user)',
+ array(
+ 'cpc_repo_id' => $this->mRepoId,
+ 'cpc_rev_id' => $this->mId,
+ ),
+ __METHOD__
+ );
+ $users = array();
+ foreach ( $result as $row ) {
+ $users[$row->cpc_user] = User::newFromId(
$row->cpc_user );
+ }
+ return $users;
+ }
protected function getCommentingUsers() {
$dbr = wfGetDB( DB_SLAVE );
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
