http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71515
Revision: 71515
Author: platonides
Date: 2010-08-23 21:54:45 +0000 (Mon, 23 Aug 2010)
Log Message:
-----------
Try to improve the funciton comment of getETag() per r70809 CR. Adaptation of
Nikerabbit proposal.
Modified Paths:
--------------
trunk/phase3/includes/parser/ParserCache.php
Modified: trunk/phase3/includes/parser/ParserCache.php
===================================================================
--- trunk/phase3/includes/parser/ParserCache.php 2010-08-23 21:52:15 UTC
(rev 71514)
+++ trunk/phase3/includes/parser/ParserCache.php 2010-08-23 21:54:45 UTC
(rev 71515)
@@ -55,10 +55,14 @@
}
/**
- * Provides an E-Tag suitable for the whole page, even if $article is
- * just the main wikitext. So it uses the complete set of user options.
- * Most importantly, that includes the user language, but other options
- * would give problems on some setups, too.
+ * Provides an E-Tag suitable for the whole page. Note that $article
+ * is just the main wikitext. The E-Tag has to be unique to the whole
+ * page, even if the article itself is the same, so it uses the
+ * complete set of user options. We don't want to use the preference
+ * of a different user on a message just because it wasn't used in
+ * $article. For example give a Chinese interface to a user with
+ * English preferences. That's why we take into account *all* user
+ * options. (r70809 CR)
*/
function getETag( $article, $popts ) {
return 'W/"' . $this->getParserOutputKey( $article,
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
