http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88782

Revision: 88782
Author:   janpaul123
Date:     2011-05-25 11:05:53 +0000 (Wed, 25 May 2011)
Log Message:
-----------
Removed some return false; statements per 
http://www.mediawiki.org/wiki/User:Krinkle/Extension_review/WikiLove

Modified Paths:
--------------
    trunk/extensions/WikiLove/wikiLove.js

Modified: trunk/extensions/WikiLove/wikiLove.js
===================================================================
--- trunk/extensions/WikiLove/wikiLove.js       2011-05-25 11:03:06 UTC (rev 
88781)
+++ trunk/extensions/WikiLove/wikiLove.js       2011-05-25 11:05:53 UTC (rev 
88782)
@@ -178,7 +178,6 @@
                        $( '#wlPreview' ).hide();
                        $.wikiLove.previewData = null;
                }
-               return false;
        },
        
        /*
@@ -309,7 +308,6 @@
                if ( $( '#wlNotifyCheckbox:checked' ).val() && 
$.wikiLove.emailable ) {
                        $.wikiLove.previewData.mail = $.wikiLove.prepareMsg( 
$.wikiLove.currentTypeOrSubtype.mail );
                }
-               return false;
        },
        
        showError: function( errmsg ) {
@@ -385,7 +383,6 @@
                e.preventDefault();
                $.wikiLove.doSend( $.wikiLove.previewData.header, 
$.wikiLove.previewData.msg,
                        $.wikiLove.previewData.type, 
$.wikiLove.previewData.notify );
-               return false;
        },
        
        /*
@@ -482,7 +479,6 @@
                                                                                
$( '#wlGallery a' ).removeClass( 'selected' );
                                                                                
$( this ).addClass( 'selected' );
                                                                                
$( '#wlImage' ).val( $.wikiLove.gallery[$( this ).attr( 'id' )] );
-                                                                               
return false;
                                                                        }) 
                                                        );
                                                        
$.wikiLove.gallery['wlGalleryImg' + index] = page.title;
@@ -562,7 +558,6 @@
                                                                                
        $( '#wlGallery a' ).removeClass( 'selected' );
                                                                                
        $( this ).addClass( 'selected' );
                                                                                
        $( '#wlImage' ).val( $.wikiLove.gallery[$( this ).attr( 'id' )] );
-                                                                               
        return false;
                                                                                
})
                                                                );
                                                                
@@ -590,7 +585,6 @@
                $( '#ca-wikilove a' ).click( function( e ) {
                        $.wikiLove.openDialog();
                        e.preventDefault();
-                       return false;
                });
        }
 };


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to