http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92429
Revision: 92429
Author: reedy
Date: 2011-07-18 13:14:05 +0000 (Mon, 18 Jul 2011)
Log Message:
-----------
Kill unused globals
Remove unreachable return;
Modified Paths:
--------------
trunk/phase3/includes/specials/SpecialLockdb.php
trunk/phase3/includes/specials/SpecialMovepage.php
trunk/phase3/includes/specials/SpecialPasswordReset.php
trunk/phase3/includes/specials/SpecialUnblock.php
trunk/phase3/includes/specials/SpecialUploadStash.php
Modified: trunk/phase3/includes/specials/SpecialLockdb.php
===================================================================
--- trunk/phase3/includes/specials/SpecialLockdb.php 2011-07-18 13:10:29 UTC
(rev 92428)
+++ trunk/phase3/includes/specials/SpecialLockdb.php 2011-07-18 13:14:05 UTC
(rev 92429)
@@ -34,7 +34,7 @@
}
public function execute( $par ) {
- global $wgUser, $wgOut, $wgRequest;
+ global $wgUser, $wgRequest;
$this->setHeaders();
Modified: trunk/phase3/includes/specials/SpecialMovepage.php
===================================================================
--- trunk/phase3/includes/specials/SpecialMovepage.php 2011-07-18 13:10:29 UTC
(rev 92428)
+++ trunk/phase3/includes/specials/SpecialMovepage.php 2011-07-18 13:14:05 UTC
(rev 92429)
@@ -579,7 +579,7 @@
}
function showSubpages( $title, $out ) {
- global $wgUser, $wgLang;
+ global $wgLang;
if( !MWNamespace::hasSubpages( $title->getNamespace() ) )
return;
Modified: trunk/phase3/includes/specials/SpecialPasswordReset.php
===================================================================
--- trunk/phase3/includes/specials/SpecialPasswordReset.php 2011-07-18
13:10:29 UTC (rev 92428)
+++ trunk/phase3/includes/specials/SpecialPasswordReset.php 2011-07-18
13:14:05 UTC (rev 92429)
@@ -33,8 +33,6 @@
}
public function userCanExecute( User $user ) {
- global $wgPasswordResetRoutes, $wgAuth;
-
$error = $this->canChangePassword( $user );
if ( is_string( $error ) ) {
throw new ErrorPageError( 'internalerror', $error );
@@ -243,7 +241,7 @@
* @return Bool
*/
function isListed() {
- global $wgPasswordResetRoutes, $wgAuth, $wgUser;
+ global $wgUser;
if ( $this->canChangePassword( $wgUser ) === true ) {
return parent::isListed();
Modified: trunk/phase3/includes/specials/SpecialUnblock.php
===================================================================
--- trunk/phase3/includes/specials/SpecialUnblock.php 2011-07-18 13:10:29 UTC
(rev 92428)
+++ trunk/phase3/includes/specials/SpecialUnblock.php 2011-07-18 13:14:05 UTC
(rev 92429)
@@ -46,7 +46,6 @@
# Check for database lock
if( wfReadOnly() ) {
throw new ReadOnlyError;
- return;
}
list( $this->target, $this->type ) =
SpecialBlock::getTargetAndType( $par, $wgRequest );
Modified: trunk/phase3/includes/specials/SpecialUploadStash.php
===================================================================
--- trunk/phase3/includes/specials/SpecialUploadStash.php 2011-07-18
13:10:29 UTC (rev 92428)
+++ trunk/phase3/includes/specials/SpecialUploadStash.php 2011-07-18
13:14:05 UTC (rev 92429)
@@ -333,7 +333,6 @@
$form->prepareForm();
$formResult = $form->tryAuthorizedSubmit();
-
// show the files + form, if there are any, or just say there
are none
$refreshHtml = Html::element( 'a',
array( 'href' => $this->getTitle()->getLocalURL() ),
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
