http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93567
Revision: 93567 Author: kaldari Date: 2011-07-31 03:00:48 +0000 (Sun, 31 Jul 2011) Log Message: ----------- follow-up to r93566, more foolproof fix Modified Paths: -------------- trunk/extensions/CentralNotice/special/SpecialBannerController.php Modified: trunk/extensions/CentralNotice/special/SpecialBannerController.php =================================================================== --- trunk/extensions/CentralNotice/special/SpecialBannerController.php 2011-07-31 02:55:59 UTC (rev 93566) +++ trunk/extensions/CentralNotice/special/SpecialBannerController.php 2011-07-31 03:00:48 UTC (rev 93567) @@ -166,7 +166,7 @@ $script .= "\n\t\tvar url = '" . Xml::escapeJsString( $wgNoticeFundraisingUrl ) . "';"; $script .= <<<JAVASCRIPT - if ( bannerJson.landingPages && bannerJson.landingPages.length ) { + if ( ( bannerJson.landingPages !== null ) && bannerJson.landingPages.length ) { targets = String( bannerJson.landingPages ).split(','); url += "?" + jQuery.param( { 'landing_page': targets[Math.floor( Math.random() * targets.length )].replace( /^\s+|\s+$/, '' ) _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs