http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93817
Revision: 93817 Author: krinkle Date: 2011-08-03 11:59:11 +0000 (Wed, 03 Aug 2011) Log Message: ----------- Fix noglobals exceptions from QUnit * Test results prior to this commit: http://i.imgur.com/m8rbk.png * http://localhost/trunkw/tests/qunit/?noglobals=1 - Missing var-statement, causes global scope implication - Missing semi colon, causing next to be global Modified Paths: -------------- trunk/phase3/resources/jquery/jquery.textSelection.js trunk/phase3/resources/mediawiki/mediawiki.Title.js Modified: trunk/phase3/resources/jquery/jquery.textSelection.js =================================================================== --- trunk/phase3/resources/jquery/jquery.textSelection.js 2011-08-03 11:39:57 UTC (rev 93816) +++ trunk/phase3/resources/jquery/jquery.textSelection.js 2011-08-03 11:59:11 UTC (rev 93817) @@ -454,7 +454,7 @@ context.fn.restoreSelection(); needSave = true; } - retval = ( hasIframe ? context.fn : fn )[command].call( this, options ); + var retval = ( hasIframe ? context.fn : fn )[command].call( this, options ); if ( hasIframe && needSave ) { context.fn.saveSelection(); } Modified: trunk/phase3/resources/mediawiki/mediawiki.Title.js =================================================================== --- trunk/phase3/resources/mediawiki/mediawiki.Title.js 2011-08-03 11:39:57 UTC (rev 93816) +++ trunk/phase3/resources/mediawiki/mediawiki.Title.js 2011-08-03 11:59:11 UTC (rev 93817) @@ -120,7 +120,7 @@ * @return {mw.Title} */ setAll = function( title, s ) { - var matches = s.match( /^(?:([^:]+):)?(.*?)(?:\.(\w{1,5}))?$/ ); + var matches = s.match( /^(?:([^:]+):)?(.*?)(?:\.(\w{1,5}))?$/ ), ns_match = getNsIdByName( matches[1] ); if ( matches.length && ns_match ) { if ( matches[1] ) { title._ns = ns_match; } _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
