http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97339

Revision: 97339
Author:   reedy
Date:     2011-09-16 21:50:30 +0000 (Fri, 16 Sep 2011)
Log Message:
-----------
Code cleanup

Add README

Fix php4 style constructor in backup.inc

Modified Paths:
--------------
    trunk/extensions/ActiveAbstract/AbstractFilter.php
    trunk/phase3/maintenance/backup.inc

Added Paths:
-----------
    trunk/extensions/ActiveAbstract/README

Modified: trunk/extensions/ActiveAbstract/AbstractFilter.php
===================================================================
--- trunk/extensions/ActiveAbstract/AbstractFilter.php  2011-09-16 21:41:33 UTC 
(rev 97338)
+++ trunk/extensions/ActiveAbstract/AbstractFilter.php  2011-09-16 21:50:30 UTC 
(rev 97339)
@@ -22,7 +22,6 @@
        /**
         * Register the filter function with the dump manager
         * @param BackupDumper $dumper
-        * @static
         */
        function register( &$dumper ) {
                $dumper->registerFilter( 'abstract', 'AbstractFilter' );
@@ -237,11 +236,10 @@
                        __METHOD__ );
 
                $links = array();
-               while ( $row = $dbr->fetchObject( $result ) ) {
+               foreach( $result as $row ) {
                        $category = Title::makeTitle( NS_CATEGORY, $row->cl_to 
);
                        $links[$category->getText()] = 
$category->getCanonicalUrl();
                }
-               $dbr->freeResult( $result );
 
                return $links;
        }

Added: trunk/extensions/ActiveAbstract/README
===================================================================
--- trunk/extensions/ActiveAbstract/README                              (rev 0)
+++ trunk/extensions/ActiveAbstract/README      2011-09-16 21:50:30 UTC (rev 
97339)
@@ -0,0 +1 @@
+This "extension" is a plugin for dumpBackup
\ No newline at end of file


Property changes on: trunk/extensions/ActiveAbstract/README
___________________________________________________________________
Added: svn:eol-style
   + native

Modified: trunk/phase3/maintenance/backup.inc
===================================================================
--- trunk/phase3/maintenance/backup.inc 2011-09-16 21:41:33 UTC (rev 97338)
+++ trunk/phase3/maintenance/backup.inc 2011-09-16 21:50:30 UTC (rev 97339)
@@ -56,7 +56,14 @@
        var $revCountLast = 0;
        var $ID = 0;
 
-       function BackupDumper( $args ) {
+       var $outputTypes = array(), $filterTypes = array();
+
+       /**
+        * @var LoadBalancer
+        */
+       protected $lb;
+
+       function __construct( $args ) {
                $this->stderr = fopen( "php://stderr", "wt" );
 
                // Built-in output and filter plugins


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to