https://www.mediawiki.org/wiki/Special:Code/MediaWiki/101257
Revision: 101257 Author: nikerabbit Date: 2011-10-29 12:26:17 +0000 (Sat, 29 Oct 2011) Log Message: ----------- Looks like my simple Ajax buttons cause two different bugs in two different browsers * Firefox marks same number of buttons disabled on page refresh what there was before refresh * Chrome fails to submit ajax requests in https mode about 90% of the time This commit fixes the bug with Firefox by giving unique name attribute to the buttons Modified Paths: -------------- trunk/extensions/Translate/utils/MessageTable.php Modified: trunk/extensions/Translate/utils/MessageTable.php =================================================================== --- trunk/extensions/Translate/utils/MessageTable.php 2011-10-29 11:54:18 UTC (rev 101256) +++ trunk/extensions/Translate/utils/MessageTable.php 2011-10-29 12:26:17 UTC (rev 101257) @@ -218,6 +218,7 @@ 'class' => 'mw-translate-messagereviewbutton', 'data-token' => ApiTranslationReview::getToken( 0, '' ), 'data-revision' => $revision, + 'name' => 'acceptbutton-' . $revision, // Otherwise Firefox disables buttons on page load ); $reviewers = (array) $message->getProperty( 'reviewers' ); _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs