https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108077
Revision: 108077 Author: bsitu Date: 2012-01-04 19:58:01 +0000 (Wed, 04 Jan 2012) Log Message: ----------- followup to -r108073 - Adding Proto_canonical to wfexpandurl() and drop the use of empty() to avoid hidden bugs Modified Paths: -------------- trunk/extensions/MoodBar/FeedbackResponseItem.php trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php Modified: trunk/extensions/MoodBar/FeedbackResponseItem.php =================================================================== --- trunk/extensions/MoodBar/FeedbackResponseItem.php 2012-01-04 19:51:44 UTC (rev 108076) +++ trunk/extensions/MoodBar/FeedbackResponseItem.php 2012-01-04 19:58:01 UTC (rev 108077) @@ -285,7 +285,7 @@ */ public static function update( $mbfr_id, $values ) { - if ( empty( $values ) ) { + if ( !$values ) { return; } Modified: trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php =================================================================== --- trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php 2012-01-04 19:51:44 UTC (rev 108076) +++ trunk/extensions/MoodBar/include/MoodBarHTMLEmailNotification.php 2012-01-04 19:58:01 UTC (rev 108077) @@ -265,7 +265,7 @@ foreach ( $pageObject as $key => $value ) { $links[$key.'Url'] = wfExpandUrl( wfAppendQuery( $clickTrackingLink, array( 'redirectto' => $value->getLinkURL(), - 'namespacenumber' => $value->getNamespace() ) ) ); + 'namespacenumber' => $value->getNamespace() ) ), PROTO_CANONICAL ); } } _______________________________________________ MediaWiki-CVS mailing list MediaWiki-CVS@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs