https://www.mediawiki.org/wiki/Special:Code/MediaWiki/113545
Revision: 113545
Author: catrope
Date: 2012-03-09 23:27:28 +0000 (Fri, 09 Mar 2012)
Log Message:
-----------
(bug 34521) Returning to the previous page after logging in loses any
array-valued parameters in the query string. This happens because
WebRequest::getValues() calls getVal() which strips arrays, even though the doc
comment says that no transformation is applied. Changed getValues() to call
getGPCVal() instead. The only difference is that arrays are no longer stripped,
so the doc comment is no longer a lie
Modified Paths:
--------------
trunk/phase3/RELEASE-NOTES-1.20
trunk/phase3/includes/WebRequest.php
Modified: trunk/phase3/RELEASE-NOTES-1.20
===================================================================
--- trunk/phase3/RELEASE-NOTES-1.20 2012-03-09 23:24:38 UTC (rev 113544)
+++ trunk/phase3/RELEASE-NOTES-1.20 2012-03-09 23:27:28 UTC (rev 113545)
@@ -45,6 +45,8 @@
* (bug 34929) Show the correct diff when a section edit is rejected by the
spam
filter
* (bug 15816) Add a switch for SETting the search_path (Postgres)
+* (bug 34521) Returning to the previous page after logging in loses any array-
+ valued parameters in the query string
=== API changes in 1.20 ===
* (bug 34316) Add ability to retrieve maximum upload size from MediaWiki API.
Modified: trunk/phase3/includes/WebRequest.php
===================================================================
--- trunk/phase3/includes/WebRequest.php 2012-03-09 23:24:38 UTC (rev
113544)
+++ trunk/phase3/includes/WebRequest.php 2012-03-09 23:27:28 UTC (rev
113545)
@@ -535,7 +535,7 @@
$retVal = array();
foreach ( $names as $name ) {
- $value = $this->getVal( $name );
+ $value = $this->getGPCVal( $this->data, $name );
if ( !is_null( $value ) ) {
$retVal[$name] = $value;
}
_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs
