https://www.mediawiki.org/wiki/Special:Code/MediaWiki/114894

Revision: 114894
Author:   awjrichards
Date:     2012-04-13 22:04:36 +0000 (Fri, 13 Apr 2012)
Log Message:
-----------
Run stylize.php on dippybird

Modified Paths:
--------------
    trunk/tools/gerrit-dippybird/dippy-bird.php

Modified: trunk/tools/gerrit-dippybird/dippy-bird.php
===================================================================
--- trunk/tools/gerrit-dippybird/dippy-bird.php 2012-04-13 22:03:16 UTC (rev 
114893)
+++ trunk/tools/gerrit-dippybird/dippy-bird.php 2012-04-13 22:04:36 UTC (rev 
114894)
@@ -41,10 +41,10 @@
        );
 
        protected $validActions = array(
-               //'approve' => 'executeApprove',
-               //'verify' => 'executeVerify',
+               // 'approve' => 'executeApprove',
+               // 'verify' => 'executeVerify',
                'submit' => 'executeSubmit',
-               //'abandon' => 'executeAbandon',
+               // 'abandon' => 'executeAbandon',
        );
 
        public function __construct() {
@@ -71,7 +71,7 @@
                $results = $this->executeQuery();
 
                // execute the action to take on the query results
-               $this->{$action_method}( $results );
+               $this-> { $action_method } ( $results );
 
                echo "Thanks for playing!" . PHP_EOL;
                echo "<3," . PHP_EOL;
@@ -158,7 +158,7 @@
                $patchset_ids = array();
                foreach ( $results as $result ) {
                        $patchset_id = self::extractPatchSetId( $result );
-                       if ( !is_null( $patchset_id )) {
+                       if ( !is_null( $patchset_id ) ) {
                                $patchset_ids[] = $patchset_id;
                        }
                }
@@ -172,7 +172,7 @@
         */
        public static function extractPatchSetId( $result ) {
                $changeset = json_decode( $result, true );
-               if( isset( $changeset['currentPatchSet']['revision'] ) ) {
+               if ( isset( $changeset['currentPatchSet']['revision'] ) ) {
                        return $changeset['currentPatchSet']['revision'];
                }
                return null;
@@ -433,7 +433,7 @@
                if ( !$this->isValidAction( $action ) ) {
                        $msg = "Invalid action requested" . PHP_EOL;
                        $msg .= "Valid actions include:" . PHP_EOL;
-                       foreach( $this->validActions as $action => $method ) {
+                       foreach ( $this->validActions as $action => $method ) {
                                $msg .= "\t$action" . PHP_EOL;
                        }
                        $this->bail( 1, $msg );


_______________________________________________
MediaWiki-CVS mailing list
MediaWiki-CVS@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-cvs

Reply via email to