ext Arjan van de Ven wrote:
+n900: kernel.spec.in series makespec.pl
+ @touch N900;
+ @perl makespec.pl< kernel.spec.in> kernel-n900.spec ;
why make a separate spec like this? sounds completely unneeded to me....
for arm it will only build the n900 anyway right now
In future we should see more ARM platforms. we cannot say that arm = N900.
-tmp-arm-config: config-arm-generic config-generic
- perl merge.pl $^> $@
-
-kernel-n900.config: config-arm-n900 tmp-arm-config
- perl merge.pl $^> $@
+kernel-arm-n900.config: config-arm-n900
+ cp $^ $@
please don't do this and use our hierarchical configuration system
it's very important for meego to have as consistent configurations as possible.
Currently config-generic is more x86 specific it even has ARCH=x86.
so currently config-generic is broken.
And how can we ensure that this config-generic is compatible to all platforms?
@@ -676,13 +683,13 @@ for cfg in kernel-*.config; do
done
# now run oldconfig over all the config files
-for i in *.config
+for i in %{all_arch_configs}
please always run all oldconfigs for all architectures for each build.
this way a developer that adds a config option is reminded to add it to all the
right places
on his own machine, independent of what architecture he is currently building
on.
this is the snippet which runs before the run oldconfig
# Remove configs not for the buildarch
for cfg in kernel-*.config; do
if [ `echo %{all_arch_configs} | grep -c $cfg` -eq 0 ]; then
rm -f $cfg
fi
done
So are u suggesting that this must not be done?
-roger
_______________________________________________
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev
