Hi Greg,

On Fri, 2010-06-11 at 16:44 +0200, ext Greg KH wrote:
> On Fri, Jun 11, 2010 at 03:43:44PM +0300, Ameya Palande wrote:
> > 1. Remove -q, QUIET, symbol and EXTRA_SYMBOL options.
> 
> Why?

Why do we need -v and -q both? Current behavior is quiet by default, and
if one needs verbose operation then you can specify -v=1. 

EXTRA_SYMBOL and symbol were not used so I removed them.

> > 2. Use -f instead of -F for fuzz to maintain consistency
> > 3. Introduce --verbose and (-q) short option for --quilt.
> 
> You just changed the meaning of an existing symbol, that might cause
> problems.

I agree and thats why I sent second version which doesn't alter the -F
option.

> What's wrong with long options?

Nothing wrong. I just wanted to provide both long and short options :)

Thanks for the review!

Cheers,
Ameya.

_______________________________________________
MeeGo-dev mailing list
[email protected]
http://lists.meego.com/listinfo/meego-dev

Reply via email to