Em quinta-feira, 31 de março de 2011, às 12:11:58, miroslav.s...@tieto.com escreveu: > Hi, > we have a bit discussion if we can integrate newer libmeegotouch to Meego > 1.2. Attached is report between integrated 0.20.89 and proposed current > upstream 0.20.100. > > So any comments welcomed.
High risk issues:
- MApplication::notify( QObject*, QEvent* )
False positive, checker tool bug. This is not a new virtual, this is an
overridden virtual from QCoreApplication. Overriding existing virtuals is
permitted, provided that calling of the old method by more-derived classes is
acceptable.
- MSortFilterProxyModel::lessThan( QModelIndex const&, QModelIndex const& )
const
False positive, checker tool bug, same reason.
- MWidgetViewPrivate size change
Private class, so size changes are not issues.
Medium risk issues:
- MStyleSheetParser::StylesheetFileInfo::fromMapedMemory
I'm going to guess that this is an older, obsolete method that was removed due
to the misspelling ("maped" -> "mapped"). If no one was using it, it's ok to
remove. But it is a BC change.
Low risk issues:
- MStyleSheetPrivate::SelectorInfoList::selectorInfos
Private class, no issue.
- MStyleSheetParser::StylesheetFileInfo
Seems like a real issue, unless this is a private class.
- MTextEdit::retranslateUi( )
No issue.
- MToolBarView::orientationChangeEvent( MOrientationChangeEvent* )
No issue.
- MWidgetViewPrivate
Private class, no issue.
- MStyleSheetSelector
Incompatible change, unless this is a private class.
So I'd say check whether the stylesheet parser in MTF is public API or not. If
it's public API, these are BIC changes. Otherwise, the upgrade is completely
safe.
Even if it's BIC, there was no BC promise for MTF, so the upgrade can be done
provided everything linking to MTF is recompiled.
--
Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org
Senior Product Manager - Nokia, Qt Development Frameworks
PGP/GPG: 0x6EF45358; fingerprint:
E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ MeeGo-dev mailing list MeeGo-dev@meego.com http://lists.meego.com/listinfo/meego-dev http://wiki.meego.com/Mailing_list_guidelines
