Hi, Yes, you are right. Please find attached a corrected patch.
Kr,
Chris.
On Tue, Jun 14, 2011 at 9:36 PM, Patrick Ohly <patrick.o...@intel.com> wrote:
> On Di, 2011-06-14 at 18:33 +0100, Dumez, Christophe wrote:
>> +++ b/libekcal.pc.in
>> @@ -0,0 +1,10 @@
>> +prefix=/usr
>> +exec_prefix=${prefix}
>> +libdir=${exec_prefix}/lib
>> +includedir=${prefix}/include
>> +
>> +Name: libekcal
>> +Description: EDS calendar storage for KCalCore
>> +Version: @VERSION@
>> +Requires: QtCore QtGui uuid libkcalcoren libecal-1.2 >= 2.30
>> libedataserver-1.2 >= 2.30 libical >= 0.44 glib-2.0
>> +Libs: -L${libdir} -lekcal
>
> The prefix shouldn't be hard-coded to /usr. When configure is run
> without arguments, the default is /usr/local. It might be anything once
> --prefix is used.
>
> Better use this:
>
> prefix=@prefix@
> exec_prefix=@exec_prefix@
> libdir=@libdir@
> includedir=@includedir@
>
> Then configure will insert the real values when turning the .pc.in file
> into .pc.
>
>> diff --git a/m4-repo/pkgconfig.m4 b/m4-repo/pkgconfig.m4
>> new file mode 100644
>> index 0000000..a0b9cd4
>> --- /dev/null
>> +++ b/m4-repo/pkgconfig.m4
>> @@ -0,0 +1,155 @@
>
> Why is this getting added? Generating the .pc file does not depend on
> the macros provided by it, does it?
>
> --
> Best Regards, Patrick Ohly
>
> The content of this message is my personal opinion only and although
> I am an employee of Intel, the statements I make here in no way
> represent Intel's position on the issue, nor am I authorized to speak
> on behalf of Intel on this matter.
>
>
>
--
Dr. Christophe Dumez
Linux Software Engineer
Intel Finland Oy - Open Source Technology Center
0001-Add-libekcal.pc-pkgconfig-file.patch
Description: Binary data
_______________________________________________ MeeGo-dev mailing list MeeGo-dev@meego.com http://lists.meego.com/listinfo/meego-dev http://wiki.meego.com/Mailing_list_guidelines
