On Tue, Oct 19, 2010 at 12:09:35AM +0100, Brouat, Claude wrote:
> Hi,
> 
> Here is a patch that provides support for the TI WL1273 WLAN chipset on Intel 
> platform.
> It also includes an mmc workaround on 2.6.35 version. A clean
> implementation of this workaround was submitted/accepted to 2.6.36
> kernel.  The current workaround is meant at supporting a WL1273
> chipset specific reset sequence.
> 
> It applies on current meego kernel and provides delta code for WLAN only.
> All this work is in the process of being upstreamed on kernel.org by
> TI or is already partially upstreamed on Linux next.  So, this patch
> will be replaced in the next weeks by upstreamed patches that will be
> back-ported from Linux next to meego kernel.

You just backported the whole mac80211 subsystem from .36 to .35.  Isn't
that a bit extreme for a single network driver?

How much have you tested all other wireless drivers with this patchset?
And why not break it out into the individual pieces of the patches,
which will properly preserve the author and reviewer of the patches, as
well as making it easier to review and merge and maintain over time.

As this is, I think it would be insane for it to be accepted, it's just
too large and unreviewable.

thanks,

greg k-h
_______________________________________________
Meego-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to