Hi Ken,
On Wed, 2010-10-20 at 01:00 +0200, ext Ken Lierman wrote:
> Add initial ak8975 eCompass driver.
>
> We are aware of the conflicting upstream driver, and need a get well
> plan to align/merge with it, but this version is currently required.
>
> Patch from: <[email protected]>
> Signed-off-by: Ken Lierman <[email protected]>
It is clearly visible that you forgot to run checkpatch.pl on this patch
before submitting it to this mailing list. I have attached its output
with this email.
Can you take a look at it?
Thanks!
Cheers,
Ameya.
WARNING: please write a paragraph that describes the config symbol fully
#28: FILE: drivers/misc/Kconfig:340:
+ help
ERROR: do not initialise statics to 0 or NULL
#141: FILE: drivers/misc/ak8975.c:90:
+static unsigned char power_state = false;
WARNING: line over 80 characters
#192: FILE: drivers/misc/ak8975.c:141:
+ unsigned short *xc, unsigned short *yc, unsigned short *zc)
WARNING: line over 80 characters
#206: FILE: drivers/misc/ak8975.c:155:
+ temp = i2c_smbus_read_byte_data(client, REG_HXL);
WARNING: line over 80 characters
#209: FILE: drivers/misc/ak8975.c:158:
+ temp = i2c_smbus_read_byte_data(client, REG_HYL);
WARNING: line over 80 characters
#212: FILE: drivers/misc/ak8975.c:161:
+ temp = i2c_smbus_read_byte_data(client, REG_HZL);
WARNING: line over 80 characters
#215: FILE: drivers/misc/ak8975.c:164:
+ /* Check for an error (status clears when read) */
WARNING: line over 80 characters
#216: FILE: drivers/misc/ak8975.c:165:
+ status = i2c_smbus_read_byte_data(client, REG_ST2);
WARNING: line over 80 characters
#222: FILE: drivers/misc/ak8975.c:171:
+ /* set the current field values and we're done */
WARNING: line over 80 characters
#264: FILE: drivers/misc/ak8975.c:213:
+ /* Enter internal Power Down mode prior to enabling internal field generator */
WARNING: line over 80 characters
#273: FILE: drivers/misc/ak8975.c:222:
+ /* Enter Self Test Mode and retrieve the measured/adjusted field values */
WARNING: line over 80 characters
#288: FILE: drivers/misc/ak8975.c:237:
+ /* Disable internal field generation (sensor powers-down automatically) */
WARNING: braces {} are not necessary for any arm of this statement
#318: FILE: drivers/misc/ak8975.c:267:
+ if (set_val == 1) {
[...]
+ } else if (set_val == 0) {
[...]
+ } else
[...]
WARNING: line over 80 characters
#359: FILE: drivers/misc/ak8975.c:308:
+static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR, power_mode_show, power_mode_store);
WARNING: line over 80 characters
#377: FILE: drivers/misc/ak8975.c:326:
+static int ak8975_probe(struct i2c_client *client, const struct i2c_device_id *id)
WARNING: line over 80 characters
#404: FILE: drivers/misc/ak8975.c:353:
+ /* Verify connectivity/presence of the AK8975 by reading the Device ID */
WARNING: line over 80 characters
#409: FILE: drivers/misc/ak8975.c:358:
+ dev_info(&client->dev, "%s compass chip NOT found !\n", client->name);
ERROR: Missing Signed-off-by: line(s)
total: 2 errors, 16 warnings, 440 lines checked
./0001-Add-driver-for-AK8975-eCompass.patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
_______________________________________________
Meego-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
