R, Durgadoss Thu, 21 Oct 2010 18:13:39 +0530 >+extern int (*platform_thermal_notify)(__u64 msr_val); >+/*platform thermal notifier */
>+int (*platform_thermal_notify)(__u64 msr_val) = NULL; I did not see anywhere else this function pointer is used other than > + platform_thermal_notify = NULL; > + platform_thermal_notify = coretemp_interrupt; a few times. So i am wondering if this global pointer is needed, or perhaps put the logic inside coretemp_interrupt(), so there is no need to assign NULL back and forth. >+ l = apic_read(APIC_LVTTHMR); >+ apic_write(APIC_LVTTHMR, l | APIC_LVT_MASKED); >+ platform_thermal_notify = NULL; >+ rdmsr_on_cpu(data->id, MSR_IA32_THERM_INTERRUPT, &eax, &edx); could you program local APIC on one CPU and read MSR from another? _______________________________________________ Meego-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
