On 10/20/2010 10:31 PM, R, Durgadoss wrote:
Hi Arjan,
/* CTL2 register defines */
-#define MCI_CTL2_CMCI_EN (1ULL<< 30)
-#define MCI_CTL2_CMCI_THRESHOLD_MASK 0x7fffULL
+#define MCI_CTL2_CMCI_EN (1ULL<< 30)
+#define MCI_CTL2_CMCI_THRESHOLD_MASK 0x7fffULL
what is this change for ?
Index: ac_kernel/kernel/arch/x86/include/asm/msr-index.h
===================================================================
--- ac_kernel.orig/kernel/arch/x86/include/asm/msr-index.h
+++ ac_kernel/kernel/arch/x86/include/asm/msr-index.h
@@ -20,7 +20,6 @@
#define _EFER_LMA 10 /* Long mode active (read-only) */
#define _EFER_NX 11 /* No execute enable */
#define _EFER_SVME 12 /* Enable virtualization */
-#define _EFER_LMSLE 13 /* Long Mode Segment Limit Enable */
why are you removing this MSR value ?
+#define CMCI_EN (1ULL<< 30)
+#define CMCI_THRESHOLD_MASK 0xffffULL
+
I dont see where you use these in your driver ??
#define MSR_P6_PERFCTR0 0x000000c1
#define MSR_P6_PERFCTR1 0x000000c2
#define MSR_P6_EVNTSEL0 0x00000186
@@ -158,6 +159,8 @@
#define MSR_K7_FID_VID_STATUS 0xc0010042
/* K6 MSRs */
+#define MSR_K6_EFER 0xc0000080
+#define MSR_K6_STAR 0xc0000081
excuse me? do you need this really for Medfield DTS ?
did you read your patch before hitting "send" ?
-#define THERM_STATUS_POWER_LIMIT (1 << 10)
+#define THERM_STATUS_POWER_LIMIT (1 << 10)
more whitespace damage. Please be more careful with that.. that's a
nightmare for maintenance.
/* How long to wait between reporting thermal events */
#define CHECK_INTERVAL (300 * HZ)
+#define THRES_INTERVAL (25 * HZ)
really. a change like this for every x86 out there without even a
comment in the patch changelog justifying it ?
static u32 lvtthmr_init __read_mostly;
+/*platform thermal notifier */
+int (*platform_thermal_notify)(__u64 msr_val) = NULL;
checkpatch will have given you a warning about this. please fix that
warning.
+ /* check whether handler is defined */
+ if (platform_thermal_notify) {
+ /* lower threshold reached */
what lock covers platform_thermal_notify?
how is the refcounting for modules done on it? what ensures that the
module that sets that thing does not get unloaded halfway you calling it?
not a very clean patch to be honest... it looks like a lot of random
pieces slapped together inbetween some ok code...
_______________________________________________
Meego-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
