> On Mon, Oct 25, 2010 at 01:12:07PM -0700, > [email protected] wrote: >> I asked for advice how to proceed when I gave an advanced warning I ran >> into the problem of module compilation using get_task_comm(), the >> preferred way of implementing this feature. Based on the feedback I >> got, >> this is the change I made. It's the same code, it's just encapsulated >> within the driver, so it's unobtrusive to the rest of the kernel and >> upstream drivers who access the global variable their own way. > > But this is code duplication, which in Linux, we do not want to do, as > it makes no sense. What happens when someone fixes a bug in this core > function, your driver-duplicated version would never see that fix. It > would also be grounds for not getting the driver into the kernel, which > you are working toward, right? >
I already sent the kernel bug patch for Arjan to include in Meego this morning. > thanks, > > greg k-h > _______________________________________________ Meego-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
