On Thu, Nov 04, 2010 at 10:18:13AM -0400, Arjan van de Ven wrote: > On 11/3/2010 5:55 PM, Ken Lierman wrote: >> + mfld_mxt_platform_data.max_x = 480; >> + mfld_mxt_platform_data.max_y = 864; > > hardcoding this sounds like a trainwreck to me.
These are being used to configure the valid event range on the input device, but I don't see these values being used to configure the device anywhere. Based on my experiments with the qt600240_ts driver, does the mXT224 have some non-volatile storage with device configuration and calibration information?[*] If so, should the driver be reading these values from the controller instead of getting them from platform data? [*] qt602240_ts reprogrammed something in the controller, and now I've got two devices that don't generate events at all even when I use the atmel_maxtouch driver. > > > + mxt_reset_gpio = 129; /* TODO: Use SFI, when SFI is available */ > > and this is not an option either. And this gpio is exported in the most recent firmware as TS0-reset, so this should be an easy fix. - Chris _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
