Agreed with Feng, the real fix for the issue would be in SCU FW which is WIP.

Leo

-----Original Message-----
From: [email protected] 
[mailto:[email protected]] On Behalf Of Tang, Feng
Sent: Friday, November 12, 2010 12:29 AM
To: Zhou, Ryan; [email protected]
Cc: Lian, ZhenlinX
Subject: Re: [Meego-kernel] [PATCH] SCU FW: Fix SCU FW leap year issue.

No.
It should be 1960 as offset, which has been discussed with FW team

Thanks,
Feng
>-----Original Message-----
>From: [email protected]
>[mailto:[email protected]] On Behalf Of Zhou, Ryan
>Sent: 2010年11月12日 16:22
>To: [email protected]
>Cc: Lian, ZhenlinX
>Subject: [Meego-kernel] [PATCH] SCU FW: Fix SCU FW leap year issue.
>
>From 81a4015c0de825f3ce09b1b3c0ee06d6fe4ed750 Mon Sep 17 00:00:00 2001
>From: Sang, Shuduo <[email protected]>
>Date: Fri, 12 Nov 2010 10:30:28 +0800
>Subject: [PATCH] SCU FW: Fix SCU FW leap year issue.
>
>The year reg's offset should be based on 1970 instead of 1960.
>
>Signed-off-by: Ryan Zhou <[email protected]>
>---
> linux-2.6.35-devel-kernel/arch/x86/kernel/vrtc.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/linux-2.6.35-devel-kernel/arch/x86/kernel/vrtc.c
>b/linux-2.6.35-devel-kernel/arch/x86/kernel/vrtc.c
>index fa1eb63..3d2f634 100644
>--- a/linux-2.6.35-devel-kernel/arch/x86/kernel/vrtc.c
>+++ b/linux-2.6.35-devel-kernel/arch/x86/kernel/vrtc.c
>@@ -71,8 +71,8 @@ unsigned long vrtc_get_time(void)
>       mon = vrtc_cmos_read(RTC_MONTH);
>       year = vrtc_cmos_read(RTC_YEAR);
>
>-      /* vRTC YEAR reg contains the offset to 1960 */
>-      year += 1960;
>+      /* vRTC YEAR reg contains the offset to 1970 */
>+      year += 1970;
>
>       printk(KERN_INFO "vRTC: sec: %d min: %d hour: %d day: %d "
>               "mon: %d year: %d\n", sec, min, hour, mday, mon, year);
>--
>1.7.0.4
>
>
>
>
>Regards
>
>Ryan
>
>_______________________________________________
>MeeGo-kernel mailing list
>[email protected]
>http://lists.meego.com/listinfo/meego-kernel
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to