> > + WARN_ON(s_attr->nr != 0&& s_attr->nr != 1);
>
> hmm WARN_ON() on user input ? that's not generally nice..
It's not user input
> > +static int enable_interrupt(struct cmd_info *cinfo)
> > +{
> > + int ret;
> > +
> > + /* Workaround till an sfi table entry comes */
> > + cinfo->irq = gpio_to_irq(30);
>
> please put in the right pieces, and don't do workarounds here...
> if any, they all need to be in mrst.c, and with a comment as to which
> version
No - they should be in the driver, because it makes it much easier to
maintain and merge.
> > +&sensor_dev_attr_accumulation_time.dev_attr.attr,
> > +&sensor_dev_attr_action_status.dev_attr.attr,
>
> this is an aweful high number of new userspace interfaces....
I've asked the ACPI folks to look at this as they also need current
monitoring and power draw stuff so the API should be common.
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel
