> +#define BATT_INTR_SRAM_ADDR  0xFFFF7FC3
> +#define BATT_OCV_SRAM_ADDR   0xFFFF3008

These should be coming from the firmware not hardcoded.

> -                     install_irq_resource(pdev, pentry->irq);
> +
> +                     if (!strcmp(pentry->name, "msic_battery"))
> +                             install_msic_batt_resources(pdev,
> pentry->irq);
> +                     else
> +                             install_irq_resource(pdev,

Please can you add a table entry and handle it in the calls from
sfi_handle_ipc_dev, that way it keeps all the device specific logic in
one spot.

Otherwise looks sane.
_______________________________________________
MeeGo-kernel mailing list
[email protected]
http://lists.meego.com/listinfo/meego-kernel

Reply via email to