Hi, This patch was tested by us for a few weeks now. We did not discover any issues related to this patch. There were discussions on upstream (see https://patchwork.kernel.org/patch/335881/) It looks like it is on the good way to be upstreamed. Let me know if you can integrate this patch in our meego kernel (in compat-wireless-2010-10-19). Else, we will have to wait for it to be in compat-wireless-2010-12-xx and pick it up.
Regards, Claude > -----Original Message----- > From: [email protected] [mailto:meego-kernel- > [email protected]] On Behalf Of Brouat, Claude > Sent: Monday, November 29, 2010 5:20 PM > To: Samuel Ortiz > Cc: [email protected] > Subject: Re: [Meego-kernel] Init of WLAN on MFLD : Patch backport > proposition > > Hi Samuel, > > > -----Original Message----- > > From: Samuel Ortiz [mailto:[email protected]] > > Sent: Monday, November 29, 2010 4:50 PM > > To: Brouat, Claude > > Cc: [email protected] > > Subject: Re: [Meego-kernel] Init of WLAN on MFLD : Patch backport > > proposition > > > > Hi Claude, > > > > On Mon, Nov 29, 2010 at 03:16:06PM +0000, Brouat, Claude wrote: > > > Hi, > > > > > > The MAC address of the Wifi wl12xx chip isn't correctly set during > > the boot sequence. > > > This results in manual operations in rc.sysinit script in order to > > set MAC and have wifi functional. > > > > > > The following patch (https://patchwork.kernel.org/patch/335881/ ) > > allows the wl12xx driver to read the MAC address from NVS file. > > > diff --git a/drivers/net/wireless/wl12xx/main.c > > b/drivers/net/wireless/wl12xx/main.c > > > index 708b699..e5fbbb6 100644 > > > --- a/drivers/net/wireless/wl12xx/main.c > > > +++ b/drivers/net/wireless/wl12xx/main.c > > > @@ -2987,6 +2987,18 @@ int wl1271_register_hw(struct wl1271 *wl) > > > if (wl->mac80211_registered) > > > return 0; > > > > > > + ret = wl1271_fetch_nvs(wl); > > > + if (ret == 0) { > > > + u8 *nvs_ptr = (u8 *)wl->nvs->nvs; > > > + > > > + wl->mac_addr[0] = nvs_ptr[11]; > > > + wl->mac_addr[1] = nvs_ptr[10]; > > > + wl->mac_addr[2] = nvs_ptr[6]; > > > + wl->mac_addr[3] = nvs_ptr[5]; > > > + wl->mac_addr[4] = nvs_ptr[4]; > > > + wl->mac_addr[5] = nvs_ptr[3]; > > > + } > > > + > > > SET_IEEE80211_PERM_ADDR(wl->hw, wl->mac_addr); > > > > > > ret = ieee80211_register_hw(wl->hw); > > > > > > If this patch is integrated, procedure to set the MAC address for > > Wifi connectivity becomes clean and very similar to the procedure > > already used to set the IMEI for modem connectivity: > > > > > > * boot the device > > > > > > * set MAC address in NVS file via the attached script > > The NVS file already contains device specific data, e.g. the RF > > calibration > > parts. So each device running a wl12xx 802.11 chip should ship with > its > > own > > and specific NVS, which should then contain a proper and unique MAC > > address. > > This is the OEM's responsibility to produce and ship proper NVS > files, > > so why > > do we need to have an additional script writing our MACs to the > > existing NVS ? > > > > Yes, you are right for final production. > But, in R&D environment, all wl12xx have the same NVS file with a > default MAC address. > BTW, in the current source code, wl12xx driver does not read MAC@ from > NVS file. So, above patch to read nvs file is required if we want this > functionality. > > Regards, > > Claude > > > Cheers, > > Samuel. > > > > -- > > Intel Open Source Technology Centre > > http://oss.intel.com/ > --------------------------------------------------------------------- > Intel Corporation SAS (French simplified joint stock company) > Registered headquarters: "Les Montalets"- 2, rue de Paris, > 92196 Meudon Cedex, France > Registration Number: 302 456 199 R.C.S. NANTERRE > Capital: 4,572,000 Euros > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > _______________________________________________ > MeeGo-kernel mailing list > [email protected] > http://lists.meego.com/listinfo/meego-kernel --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. _______________________________________________ MeeGo-kernel mailing list [email protected] http://lists.meego.com/listinfo/meego-kernel
